fix: semantic selected-text colors and proper full-screen CommandGroup#596
Merged
fix: semantic selected-text colors and proper full-screen CommandGroup#596
Conversation
…e in selected rows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two quick-win fixes from the codebase audit:
Semantic selected-text color — Replaced 15 hardcoded
.whiteforeground colors in selected/highlighted row states withColor(nsColor: .alternateSelectedControlTextColor). Fixes broken appearance in "Increase Contrast" accessibility mode and with custom accent colors. Affected views: QuickSwitcherView, ConnectionSwitcherPopover, DatabaseSwitcherSheet.Full-screen CommandGroup — Replaced
NSEvent.addLocalMonitorForEventshack for Ctrl+Cmd+F with a properCommandGroup(after: .toolbar)button. The menu system now owns the shortcut, enabling proper menu validation and the standard "Enter Full Screen" / "Exit Full Screen" title toggle.Test plan